On 8/9/20 9:10 PM, Stephen Rothwell wrote: > Hi all, > on i386: Lots (63) of left shift warnings: {not all are shown here} CC drivers/vdpa/mlx5/net/mlx5_vnet.o In file included from ../include/linux/bits.h:6:0, from ../include/linux/bitops.h:5, from ../include/linux/kernel.h:12, from ../include/linux/vdpa.h:5, from ../drivers/vdpa/mlx5/net/mlx5_vnet.c:4: ../drivers/vdpa/mlx5/net/mlx5_vnet.c: In function 'print_features': ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:27:60: note: in expansion of macro 'BIT' BIT(VIRTIO_NET_F_MQ) | BIT(VIRTIO_NET_F_CTRL_MAC_ADDR) | BIT(VIRTIO_NET_F_HASH_REPORT) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:28:3: note: in expansion of macro 'BIT' BIT(VIRTIO_NET_F_RSS) | BIT(VIRTIO_NET_F_RSC_EXT) | BIT(VIRTIO_NET_F_STANDBY) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:28:27: note: in expansion of macro 'BIT' BIT(VIRTIO_NET_F_RSS) | BIT(VIRTIO_NET_F_RSC_EXT) | BIT(VIRTIO_NET_F_STANDBY) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:28:55: note: in expansion of macro 'BIT' BIT(VIRTIO_NET_F_RSS) | BIT(VIRTIO_NET_F_RSC_EXT) | BIT(VIRTIO_NET_F_STANDBY) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:29:3: note: in expansion of macro 'BIT' BIT(VIRTIO_NET_F_SPEED_DUPLEX) | BIT(VIRTIO_F_NOTIFY_ON_EMPTY) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ ../include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:30:30: note: in expansion of macro 'BIT' BIT(VIRTIO_F_ANY_LAYOUT) | BIT(VIRTIO_F_VERSION_1) | BIT(VIRTIO_F_ACCESS_PLATFORM) | \ ^~~ ../drivers/vdpa/mlx5/net/mlx5_vnet.c:186:18: note: in expansion of macro 'VALID_FEATURES_MASK' if (features & ~VALID_FEATURES_MASK) ^~~~~~~~~~~~~~~~~~~ -- ~Randy Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>