On Tue, Jul 28, 2020 at 11:49:27AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the printk tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from include/linux/printk.h:10, > from include/linux/kernel.h:15, > from include/linux/list.h:9, > from include/linux/lockdep.h:43, > from include/linux/spinlock_types.h:18, > from include/linux/genalloc.h:32, > from drivers/soc/fsl/qe/qe_common.c:16: > include/linux/ratelimit_types.h:16:2: error: unknown type name 'raw_spinlock_t' > 16 | raw_spinlock_t lock; /* protect the state */ > | ^~~~~~~~~~~~~~ > In file included from include/linux/wait.h:9, > from include/linux/pid.h:6, > from include/linux/sched.h:14, > from include/linux/ratelimit.h:6, > from include/linux/dev_printk.h:16, > from include/linux/device.h:15, > from include/linux/node.h:18, > from include/linux/cpu.h:17, > from include/linux/of_device.h:5, > from drivers/soc/fsl/qe/qe_common.c:19: > include/linux/ratelimit.h: In function 'ratelimit_state_init': > include/linux/ratelimit.h:14:21: error: passing argument 1 of '__raw_spin_lock_init' from incompatible pointer type [-Werror=incompatible-pointer-types] > 14 | raw_spin_lock_init(&rs->lock); > include/linux/spinlock.h:102:24: note: in definition of macro 'raw_spin_lock_init' > 102 | __raw_spin_lock_init((lock), #lock, &__key, LD_WAIT_SPIN); \ > | ^~~~ > include/linux/spinlock.h:95:52: note: expected 'raw_spinlock_t *' {aka 'struct raw_spinlock *'} but argument is of type 'int *' > 95 | extern void __raw_spin_lock_init(raw_spinlock_t *lock, const char *name, > | ~~~~~~~~~~~~~~~~^~~~ > > Caused by commit > > b4a461e72bcb ("printk: Make linux/printk.h self-contained") > > This *may* be interacting with other include file changes in linux-next. > > I have reverted that commit for today. This patch depends on two patches in the tips tree. I presume this build test was done without the tips tree, right? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt