Hi all, Today's linux-next merge of the block tree got a conflict in: drivers/nvme/target/rdma.c between commit: 5733111dcd97 ("nvmet-rdma: use new shared CQ mechanism") from the rdma tree and commits: b0012dd39715 ("nvmet-rdma: use SRQ per completion vector") b09160c3996c ("nvmet-rdma: add metadata/T10-PI support") from the block tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/nvme/target/rdma.c index 2405db8bd855,d5141780592e..000000000000 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@@ -589,7 -751,8 +752,8 @@@ static void nvmet_rdma_read_data_done(s { struct nvmet_rdma_rsp *rsp = container_of(wc->wr_cqe, struct nvmet_rdma_rsp, read_cqe); - struct nvmet_rdma_queue *queue = cq->cq_context; + struct nvmet_rdma_queue *queue = wc->qp->qp_context; + u16 status = 0; WARN_ON(rsp->n_rdma <= 0); atomic_add(rsp->n_rdma, &queue->sq_wr_avail); @@@ -996,8 -1257,9 +1258,8 @@@ static int nvmet_rdma_create_queue_ib(s */ nr_cqe = queue->recv_queue_size + 2 * queue->send_queue_size; - queue->cq = ib_cq_pool_get(ndev->device, nr_cqe + 1, comp_vector, - queue->cq = ib_alloc_cq(ndev->device, queue, - nr_cqe + 1, queue->comp_vector, - IB_POLL_WORKQUEUE); ++ queue->cq = ib_cq_pool_get(ndev->device, nr_cqe + 1, queue->comp_vector, + IB_POLL_WORKQUEUE); if (IS_ERR(queue->cq)) { ret = PTR_ERR(queue->cq); pr_err("failed to create CQ cqe= %d ret= %d\n",
Attachment:
pgpGPPHjqzdjK.pgp
Description: OpenPGP digital signature