Kbuild test robot reports a smatch warning: drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting drivers/infiniband/ulp/rtrs/rtrs-clt.c:2890 rtrs_clt_request() warn: inconsistent indenting To get rid of the warning, move the while_each_path() macro to a newline. Rename the macro to end_each_path() to avoid the "while should follow close brace '}'" checkpatch error. Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") Signed-off-by: Danil Kipnis <danil.kipnis@xxxxxxxxxxxxxxx> Reported-by: kbuild test robot <lkp@xxxxxxxxx> --- v1->v2 Add fixes line drivers/infiniband/ulp/rtrs/rtrs-clt.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index 468fdd0d8713..0fa3a229d90e 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -734,7 +734,7 @@ struct path_it { (it)->i < (it)->clt->paths_num; \ (it)->i++) -#define while_each_path(it) \ +#define end_each_path(it) \ path_it_deinit(it); \ rcu_read_unlock(); \ } @@ -1193,7 +1193,8 @@ static int rtrs_clt_failover_req(struct rtrs_clt *clt, /* Success path */ rtrs_clt_inc_failover_cnt(alive_sess->stats); break; - } while_each_path(&it); + } + end_each_path(&it); return err; } @@ -2887,7 +2888,8 @@ int rtrs_clt_request(int dir, struct rtrs_clt_req_ops *ops, } /* Success path */ break; - } while_each_path(&it); + } + end_each_path(&it); return err; } -- 2.25.1