Hi all, After merging the ipmi tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user_work': drivers/char/ipmi/ipmi_msghandler.c:1156:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration] 1156 | vfree(user); | ^~~~~ | kvfree drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_create_user': drivers/char/ipmi/ipmi_msghandler.c:1188:13: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration] 1188 | new_user = vzalloc(sizeof(*new_user)); | ^~~~~~~ | kvzalloc drivers/char/ipmi/ipmi_msghandler.c:1188:11: warning: assignment to 'struct ipmi_user *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1188 | new_user = vzalloc(sizeof(*new_user)); | ^ Caused by commit d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation") I have applied the following patch for today: From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Mon, 20 Apr 2020 13:03:29 +1000 Subject: [PATCH] ipmi: vzalloc use requires vmallo.h inclusion Fixes: d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation") Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 96f157323646..9afd220cd824 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -33,6 +33,7 @@ #include <linux/workqueue.h> #include <linux/uuid.h> #include <linux/nospec.h> +#include <linux/vmalloc.h> #define IPMI_DRIVER_VERSION "39.2" -- 2.25.1 -- Cheers, Stephen Rothwell
Attachment:
pgpnDPUEWeLho.pgp
Description: OpenPGP digital signature