Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20200414 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Sun Mar 29 14:44:58 2020 +0200 1a59532382a6 ("staging: bcm2835-camera: Move video component setup in its own function") Coverity reported the following: *** CID 1492591: Code maintainability issues (UNUSED_VALUE) /drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c: 1014 in mmal_setup_video_component() 1008 if (overlay_enabled) { 1009 /* Need to disable the overlay before we can update 1010 * the resolution 1011 */ 1012 ret = vchiq_mmal_port_disable(dev->instance, preview_port); 1013 if (!ret) { vvv CID 1492591: Code maintainability issues (UNUSED_VALUE) vvv Assigning value from "vchiq_mmal_port_connect_tunnel(dev->instance, preview_port, NULL)" to "ret" here, but that stored value is overwritten before it can be used. 1014 ret = vchiq_mmal_port_connect_tunnel(dev->instance, 1015 preview_port, 1016 NULL); 1017 } 1018 } 1019 preview_port->es.video.width = f->fmt.pix.width; If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1492591 ("Code maintainability issues") Fixes: 1a59532382a6 ("staging: bcm2835-camera: Move video component setup in its own function") Thanks for your attention! -- Coverity-bot
