Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20200413 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Sat Feb 1 22:48:24 2020 +0100 e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Coverity reported the following: *** CID 1461655: Code maintainability issues (UNUSED_VALUE) /drivers/media/dvb-frontends/m88ds3103.c: 982 in m88ds3103_set_frontend() 976 /* enable/disable 192M LDPC clock */ 977 ret = m88ds3103_update_bits(dev, 0x29, 0x10, 978 (c->delivery_system == SYS_DVBS) ? 0x10 : 0x0); 979 if (ret) 980 goto err; 981 vvv CID 1461655: Code maintainability issues (UNUSED_VALUE) vvv Assigning value from "m88ds3103_update_bits(dev, 201, 8, 8)" to "ret" here, but that stored value is overwritten before it can be used. 982 ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08); 983 } 984 985 dev_dbg(&client->dev, "carrier offset=%d\n", 986 (tuner_frequency_khz - c->frequency)); 987 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1461655 ("Code maintainability issues") Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Thanks for your attention! -- Coverity-bot
