On Wed, Apr 1, 2020 at 3:29 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Wed, Apr 1, 2020 at 11:26 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Wed, Apr 1, 2020 at 10:19 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > On Wed, Apr 1, 2020 at 9:49 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > > > +EXPORT_SYMBOL_GPL(of_pinctrl_get); > > > > > > > > As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny > > > > function, what about making it an inline function in > > > > include/linux/pinctrl/pinctrl.h instead? > > > > > > I'm all for it! :) > > > > Want me to send a patch? > > Which base? > > Wouldn't we need to export the inside function in that case? > If so, we need a better name for it. And wouldn't be cost even more expensive in such case due length of the function name? -- With Best Regards, Andy Shevchenko
