Hi Stephen, On Wed, Apr 1, 2020 at 10:18 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > On Wed, 1 Apr 2020 19:08:10 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > This avoids the overheads of an EXPORTed function. > > > > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > --- > > drivers/pinctrl/devicetree.c | 6 ------ > > include/linux/pinctrl/pinctrl.h | 9 +++------ > > 2 files changed, 3 insertions(+), 12 deletions(-) > > > > This is not even build tested, but is this what you meant, Geert? > > Actually this won't work because get_pinctrl_dev_from_of_node() is > declared in the private header file drivers/pinctrl/core.h :-( Indeed :-( Just realized this myself, while reviewing your patch. Sorry for the bad suggestion. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds