Hi Geert,
On Wed, 1 Apr 2020 09:49:00 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Thanks for your patch, which I assume is a quick build fix.
Yep, rather than reverting the other patches again.
> I see LinusW has already applied it...
>
> > --- a/drivers/pinctrl/devicetree.c
> > +++ b/drivers/pinctrl/devicetree.c
> > @@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
> > {
> > return get_pinctrl_dev_from_of_node(np);
> > }
> > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
> >
> > static int dt_to_map_one_config(struct pinctrl *p,
> > struct pinctrl_dev *hog_pctldev,
>
> As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
> function, what about making it an inline function in
> include/linux/pinctrl/pinctrl.h instead?
Makes sense to me.
--
Cheers,
Stephen Rothwell
Attachment:
pgptl4FM8fjBJ.pgp
Description: OpenPGP digital signature
