Re: [PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Wed, Mar 25, 2020 at 11:40 AM Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Wed, Mar 25, 2020 at 10:33:00AM +0100, Geert Uytterhoeven wrote:
> > If CONFIG_NET_CLS_ACT=n:
> >
> >     net/netfilter/nft_fwd_netdev.c: In function ‘nft_fwd_netdev_eval’:
> >     net/netfilter/nft_fwd_netdev.c:32:10: error: ‘struct sk_buff’ has no member named ‘tc_redirected’
> >       pkt->skb->tc_redirected = 1;
> >             ^~
> >     net/netfilter/nft_fwd_netdev.c:33:10: error: ‘struct sk_buff’ has no member named ‘tc_from_ingress’
> >       pkt->skb->tc_from_ingress = 1;
> >             ^~
> >
> > Fix this by protecting this code hunk with the appropriate #ifdef.
>
> Sorry about this, and thank you for fixing up this so fast.
>
> I'm attaching an alternative fix to avoid a dependency on tc from
> netfilter. Still testing, if fine and no objections I'll formally
> submit this.

Thanks, that fixes the issue, too.
(Note that I didn't do a full build).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux