On 3/19/20 7:47 AM, Christian Brauner wrote:
> The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
> from the !CONFIG_SYSFS version and thus causes build failurs when
> !CONFIG_SYSFS is set.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
> Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
> Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
Thanks.
> ---
> include/linux/sysfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index 9e531ec76274..4beb51009b62 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj,
> }
>
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> - const struct attribute_group **groups,
> - kuid_t kuid, kgid_t kgid)
> + const struct attribute_group *groups,
> + kuid_t kuid, kgid_t kgid)
> {
> return 0;
> }
>
> base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db
>
--
~Randy
