Hi all,
Today's linux-next merge of the staging tree got a conflict in:
drivers/staging/media/allegro-dvt/allegro-core.c
between commit:
cc62c74749a3 ("media: allegro: add missed checks in allegro_open()")
from the v4l-dvb tree and commit:
e3d21cbfa978 ("staging: media: allegro: align with parenthesis")
from the staging tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc drivers/staging/media/allegro-dvt/allegro-core.c
index 3c949090e8d2,1162cc38f3fc..000000000000
--- a/drivers/staging/media/allegro-dvt/allegro-core.c
+++ b/drivers/staging/media/allegro-dvt/allegro-core.c
@@@ -2321,15 -2324,10 +2321,15 @@@ static int allegro_open(struct file *fi
0, ALLEGRO_GOP_SIZE_MAX,
1, channel->gop_size);
v4l2_ctrl_new_std(handler,
- &allegro_ctrl_ops,
- V4L2_CID_MIN_BUFFERS_FOR_OUTPUT,
- 1, 32,
- 1, 1);
+ &allegro_ctrl_ops,
+ V4L2_CID_MIN_BUFFERS_FOR_OUTPUT,
+ 1, 32,
+ 1, 1);
+ if (handler->error != 0) {
+ ret = handler->error;
+ goto error;
+ }
+
channel->fh.ctrl_handler = handler;
channel->mcu_channel_id = -1;
Attachment:
pgpurBI5jBpxp.pgp
Description: OpenPGP digital signature
