On 3/5/20 10:52 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@xxxxxxxxxxxxxxxxxx> wrote: >> >> On 3/1/20 8:35 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> After merging the scsi-mkp tree, today's linux-next build (powerpc >>> ppc64_defconfig) produced this warning: >>> >>> In file included from include/uapi/linux/posix_types.h:5, >>> from include/uapi/linux/types.h:14, >>> from include/linux/types.h:6, >>> from include/linux/list.h:5, >>> from include/linux/module.h:12, >>> from drivers/scsi/ibmvscsi/ibmvfc.c:10: >>> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del': >>> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type] >>> 8 | #define NULL ((void *)0) >>> | ^ >>> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL' >>> 3644 | return NULL; >>> | ^~~~ >>> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here >>> 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt) >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Introduced by commit >>> >>> 54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot") >> >> Thanks. I'll send the one line fix. > > I am still getting this warning, but it is now after the merge of the > scsi tree. > I sent the fix to the list, waiting for it to get pulled in: https://marc.info/?l=linux-scsi&m=158315998321290&w=2 -- Brian King Power Linux I/O IBM Linux Technology Center