On 3/3/20 7:17 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/io_uring.c: In function 'io_close':
> fs/io_uring.c:3415:3: warning: ignoring return value of 'refcount_inc_not_zero', declared with attribute warn_unused_result [-Wunused-result]
> 3415 | refcount_inc_not_zero(&req->refs);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 62e0c6b73a2c ("io_uring: make submission ref putting consistent")
That should just be a refcount_inc() and also looks like it should happen
before the async queue. I'll fix it up.
--
Jens Axboe
