Hi Stephen et al, On Thu, Feb 27, 2020 at 5:12 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > After merging the akpm tree, today's linux-next build (sparc defconfig) > failed like this: > > In file included from include/linux/list.h:9:0, > from include/linux/smp.h:12, > from include/linux/kernel_stat.h:5, > from mm/memory.c:42: > mm/memory.c: In function 'insert_pages': > mm/memory.c:1523:41: error: implicit declaration of function 'pte_index'; did you mean 'page_index'? [-Werror=implicit-function-declaration] > remaining_pages_total, PTRS_PER_PTE - pte_index(addr)); > ^ > include/linux/kernel.h:842:40: note: in definition of macro '__typecheck' > (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) > ^ > include/linux/kernel.h:866:24: note: in expansion of macro '__safe_cmp' > __builtin_choose_expr(__safe_cmp(x, y), \ > ^~~~~~~~~~ > include/linux/kernel.h:934:27: note: in expansion of macro '__careful_cmp' > #define min_t(type, x, y) __careful_cmp((type)(x), (type)(y), <) > ^~~~~~~~~~~~~ > mm/memory.c:1522:26: note: in expansion of macro 'min_t' > pages_to_write_in_pmd = min_t(unsigned long, > ^~~~~ Same issue on m68k, as per a report from kisskb. > Caused by patch > > "mm/memory.c: add vm_insert_pages()" > > sparc32 does not implement pte_index at all :-( Seems like about only half of the architectures do. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds