On Thu, Jan 9, 2020 at 1:28 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > In commit > > d5d3594db9f0 ("pinctrl: armada-37xx: Remove unneeded semicolon") > > Fixes tag > > Fixes: commit 5715092a458c ("pinctrl: armada-37xx: Add gpio support") > > has these problem(s): > > - leading word 'commit' unexpected > > Also, each line listating a fixed commit should have a Fixes: prefix and > all the commit message tags should be kept together at the end of the > commit message. Do we have to fix this? It is a trivial fix to a non-critial non-regression problem so it's not like we need those Fixes tags to get it picked to stable or anything. To me it's just some random free-form commit message. I have merged a bunch of pull requests on top so I need a real good reason to back all that out. :/ it just doesn't seem worth it. Yours, Linus Walleij