On Tue, 17 Dec 2019, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote:
>> On 12/17/19 6:07 AM, Andy Shevchenko wrote:
>> > The initial commit followed by the fix didn't take into consideration the case
>> >
>> > CONFIG_DRM_PANEL=y
>> > CONFIG_BACKLIGHT_CLASS_DEVICE=m
>> > CONFIG_DRM_I915=y
>> >
>> > where symbol devm_of_find_backlight() is not reachable from DRM subsystem.
>> > Quick fix is to avoid drm_panel_of_backlight() from exporting in such case.
>> >
>> > Fixes: 907aa265fde6 ("drm/drm_panel: fix EXPORT of drm_panel_of_backlight")
>> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
>> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
>> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
>> > Cc: Sean Paul <sean@xxxxxxxxxx>
>> > Cc: David Airlie <airlied@xxxxxxxx>
>> > Cc: Daniel Vetter <daniel@xxxxxxxx>
>> > Cc: Maxime Ripard <mripard@xxxxxxxxxx>
>> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>
>> Yes, that fixes the build error. Thanks.
>>
>> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
>
> Hi Andy - thanks for fixing this. And thanks Randy for verifying the
> fix.
> It passed my build test and is now pushed to drm-misc-next.
As I wrote in [1], this allows a configuration that builds and links,
but is silently broken. You won't get backlight support in drm panel
which would be a reasonable expectation with
CONFIG_BACKLIGHT_CLASS_DEVICE=m.
BR,
Jani.
[1] http://mid.mail-archive.com/87d0cnynst.fsf@xxxxxxxxx
--
Jani Nikula, Intel Open Source Graphics Center
