Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20191108 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: 800350a3f145 ("net/mlx5: Avoid NULL pointer dereference on steering cleanup") Coverity reported the following: *** CID 1487837: Error handling issues (CHECKED_RETURN) /drivers/net/ethernet/mellanox/mlx5/core/fs_core.c: 2479 in clean_tree() 2473 static void clean_tree(struct fs_node *node) 2474 { 2475 if (node) { 2476 struct fs_node *iter; 2477 struct fs_node *temp; 2478 vvv CID 1487837: Error handling issues (CHECKED_RETURN) vvv Calling "tree_get_node" without checking return value (as is done elsewhere 5 out of 6 times). 2479 tree_get_node(node); 2480 list_for_each_entry_safe(iter, temp, &node->children, list) 2481 clean_tree(iter); 2482 tree_put_node(node, false); 2483 tree_remove_node(node, false); 2484 } If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1487837 ("Error handling issues") Fixes: 800350a3f145 ("net/mlx5: Avoid NULL pointer dereference on steering cleanup") Thanks for your attention! -- Coverity-bot
