On Mon, Nov 04, 2019 at 09:37:58AM -0800, coverity-bot wrote: > Hello! > > This is an experimental automated report about issues detected by Coverity > from a scan of next-20191031 as part of the linux-next weekly scan project: > https://scan.coverity.com/projects/linux-next-weekly-scan > > You're getting this email because you were associated with the identified > lines of code (noted below) that were touched by recent commits: > > 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") > > Coverity reported the following: > > *** CID 1487401: Resource leaks (RESOURCE_LEAK) > /drivers/crypto/amlogic/amlogic-gxl-cipher.c: 134 in meson_cipher() > 128 keyivlen = op->keylen; > 129 > 130 ivsize = crypto_skcipher_ivsize(tfm); > 131 if (areq->iv && ivsize > 0) { > 132 if (ivsize > areq->cryptlen) { > 133 dev_err(mc->dev, "invalid ivsize=%d vs len=%d\n", ivsize, areq->cryptlen); > vvv CID 1487401: Resource leaks (RESOURCE_LEAK) > vvv Variable "bkeyiv" going out of scope leaks the storage it points to. > 134 return -EINVAL; > 135 } > 136 memcpy(bkeyiv + 32, areq->iv, ivsize); > 137 keyivlen = 48; > 138 if (rctx->op_dir == MESON_DECRYPT) { > 139 backup_iv = kzalloc(ivsize, GFP_KERNEL); > > If this is a false positive, please let us know so we can mark it as > such, or teach the Coverity rules to be smarter. If not, please make > sure fixes get into linux-next. :) For patches fixing this, please > include these lines (but double-check the "Fixes" first): > > Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> > Addresses-Coverity-ID: 1487401 ("Resource leaks") > Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") > > > Thanks for your attention! > Thanks for the report, I will send the fix soon. Regards
