Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20191031 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") Coverity reported the following: *** CID 1487403: (RESOURCE_LEAK) /drivers/crypto/amlogic/amlogic-gxl-cipher.c: 258 in meson_cipher() 252 ivsize, 0); 253 } 254 } 255 theend: 256 kzfree(bkeyiv); 257 vvv CID 1487403: (RESOURCE_LEAK) vvv Variable "backup_iv" going out of scope leaks the storage it points to. 258 return err; 259 } 260 261 static int meson_handle_cipher_request(struct crypto_engine *engine, 262 void *areq) 263 { /drivers/crypto/amlogic/amlogic-gxl-cipher.c: 156 in meson_cipher() 150 keyivlen = 32; 151 152 phykeyiv = dma_map_single(mc->dev, bkeyiv, keyivlen, 153 DMA_TO_DEVICE); 154 if (dma_mapping_error(mc->dev, phykeyiv)) { 155 dev_err(mc->dev, "Cannot DMA MAP KEY IV\n"); vvv CID 1487403: (RESOURCE_LEAK) vvv Variable "backup_iv" going out of scope leaks the storage it points to. 156 return -EFAULT; 157 } 158 159 tloffset = 0; 160 eat = 0; 161 i = 0; If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1487403 ("RESOURCE_LEAK") Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") Thanks for your attention! -- Coverity-bot
