Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20191025 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: c97ee3e0bea2 ("rtw88: add power tracking support") Coverity reported the following: *** CID 1487362: (NO_EFFECT) /drivers/net/wireless/realtek/rtw88/phy.c: 2074 in rtw_phy_pwrtrack_get_pwridx() 2068 2069 if (delta >= RTW_PWR_TRK_TBL_SZ) { 2070 rtw_warn(rtwdev, "power track table overflow\n"); 2071 return 0; 2072 } 2073 vvv CID 1487362: (NO_EFFECT) vvv Comparing an array to null is not useful: "swing_table->p", since the test will always evaluate as true. 2074 if (!swing_table || !swing_table->n || !swing_table->p) { 2075 rtw_warn(rtwdev, "swing table not configured\n"); 2076 return 0; 2077 } 2078 2079 delta_swing_table_idx_pos = swing_table->p[tbl_path]; /drivers/net/wireless/realtek/rtw88/phy.c: 2074 in rtw_phy_pwrtrack_get_pwridx() 2068 2069 if (delta >= RTW_PWR_TRK_TBL_SZ) { 2070 rtw_warn(rtwdev, "power track table overflow\n"); 2071 return 0; 2072 } 2073 vvv CID 1487362: (NO_EFFECT) vvv Comparing an array to null is not useful: "swing_table->n", since the test will always evaluate as true. 2074 if (!swing_table || !swing_table->n || !swing_table->p) { 2075 rtw_warn(rtwdev, "swing table not configured\n"); 2076 return 0; 2077 } 2078 2079 delta_swing_table_idx_pos = swing_table->p[tbl_path]; If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include: Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1487362 ("NO_EFFECT") Fixes: c97ee3e0bea2 ("rtw88: add power tracking support") Thanks for your attention! -- Coverity-bot
