Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20191025 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: 65df78bda385 ("drm/i915/tgl: Wa_1409420604") Coverity reported the following: *** CID 1487372: Integer handling issues (NO_EFFECT) /drivers/gpu/drm/i915/gt/intel_workarounds.c: 906 in tgl_gt_workarounds_init() 900 } 901 902 static void 903 tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal) 904 { 905 /* Wa_1409420604:tgl */ vvv CID 1487372: Integer handling issues (NO_EFFECT) vvv This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i915->drm.pdev->revision >= 0". 906 if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0)) 907 wa_write_or(wal, 908 SUBSLICE_UNIT_LEVEL_CLKGATE2, 909 CPSSUNIT_CLKGATE_DIS); 910 911 /* Wa_1409180338:tgl */ If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include: Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1487372 ("Integer handling issues") Fixes: 65df78bda385 ("drm/i915/tgl: Wa_1409420604") Thanks for your attention! -- Coverity-bot
