On Fri, Aug 30, 2019 at 11:55:30PM +1000, Stephen Rothwell wrote:
> Caused by commit
>
> 1c8999b3963d ("mm: introduce MADV_COLD")
> (and following commits)
>
> interacting with commit
>
> 923bfc561e75 ("pagewalk: separate function pointers from iterator data")
>
> from the hmm tree.
Yes, this is expected thanks
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 7ec7c8f6d5ab..20598df8360a 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -446,6 +446,10 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
> return 0;
> }
>
> +static const struct mm_walk_ops cold_walk_ops = {
> + .pmd_entry = madvise_cold_or_pageout_pte_range,
> +};
> +
> +static const struct mm_walk_ops pageout_walk_ops = {
> + .pmd_entry = madvise_cold_or_pageout_pte_range,
> +};
These two can be shared
Looks OK otherwise
Jason
