On Thu, 2019-08-29 at 21:48 +0000, Haiyang Zhang wrote: > > -----Original Message----- > > From: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > Sent: Thursday, August 29, 2019 2:32 PM > > To: sfr@xxxxxxxxxxxxxxxx; Eran Ben Elisha <eranbe@xxxxxxxxxxxx>; > > linux- > > next@xxxxxxxxxxxxxxx; rdunlap@xxxxxxxxxxxxx; Haiyang Zhang > > <haiyangz@xxxxxxxxxxxxx> > > Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Leon > > Romanovsky <leonro@xxxxxxxxxxxx> > > Subject: Re: linux-next: Tree for Aug 29 (mlx5) > > > > On Thu, 2019-08-29 at 12:55 -0700, Randy Dunlap wrote: > > > On 8/29/19 12:54 PM, Randy Dunlap wrote: > > > > On 8/29/19 4:08 AM, Stephen Rothwell wrote: > > > > > Hi all, > > > > > > > > > > Changes since 20190828: > > > > > > > > > > > > > on x86_64: > > > > when CONFIG_PCI_HYPERV=m > > > > > > and CONFIG_PCI_HYPERV_INTERFACE=m > > > > > > > Haiyang and Eran, I think CONFIG_PCI_HYPERV_INTERFACE was never > > supposed to be a module ? it supposed to provide an always > > available > > interface to drivers .. > > > > Anyway, maybe we need to imply CONFIG_PCI_HYPERV_INTERFACE in mlx5. > > The symbolic dependency by driver mlx5e, automatically triggers > loading of > pci_hyperv_interface module. And this module can be loaded in any > platforms. > This only works when both are modules. > Currently, mlx5e driver has #if > IS_ENABLED(CONFIG_PCI_HYPERV_INTERFACE) > around the code using the interface. > > I agree -- > Adding "select PCI_HYPERV_INTERFACE" for mlx5e will clean up these > #if's. > No, not "select", "imply". if one wants PCI_HYPERV_INTERFACE off, imply will keep it off for you. > Thanks, > - Haiyang
