Hi Heiko, Stephen,
On Fri, Aug 9, 2019 at 7:53 AM Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:
>
> On Thu, Aug 08, 2019 at 06:17:39PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20190807:
> >
> > I reverted a commit from the kbuild-current tree by request.
>
> Hello Masahiro,
>
> it looks like there is (another?) bug in kbuild. With your patch
>
> commit 421a15c167b2d1f43f287da5b75ef2704650640b (refs/bisect/bad)
> Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Date: Fri Jul 26 11:17:47 2019 +0900
>
> kbuild: clean-up subdir-ym computation
>
> The intermediate variables __subdir-{y,m} are unneeded.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
> the file modules.builtin starts to miss a lot of entries when building
> the kernel tree. Reverting that patch on top of linux-next 20190808
> restores the old behaviour.
>
> This is the diff I get without and with the above commit (s390 with
> defconfig):
>
> --- modules.builtin.ok 2019-08-09 00:39:58.148624485 +0200
> +++ modules.builtin 2019-08-09 00:40:07.878637541 +0200
You are right. This commit is bad.
Stephen, could you revert this commit for today's linux-next ?
BTW, I had dropped this commit from my branch (with another reason),
but I forgot to push it to the public place...
--
Best Regards
Masahiro Yamada
