On Mon, 29 Jul 2019 09:03:14 +0200,
Johannes Berg wrote:
>
> On Mon, 2019-07-29 at 08:58 +0200, Takashi Iwai wrote:
> > On Mon, 29 Jul 2019 06:04:04 +0200,
> > Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the origin tree, today's linux-next build (powerpc
> > > allyesconfig) produced this warning:
> > >
> > > sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get':
> > > sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity;
> > > ^~~~~~~~~~~~
> > >
> > > Introduced by commit
> > >
> > > f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> > >
> > > This warning has been around for a long time. It could possibly be
> > > suppressed by checking for errors returned by onyx_read_register().
> >
> > Yes, or simply zero-ing the variable in onyx_read_register(). The
> > current code ignores the read error and it's been OK over a decade :)
>
> Yeah, it's pretty weird that it never showed up before. I was wondering
> for a minute why I was CC'ed on a sound merge issue :-)
Maybe switched to a new gcc version?
> Do you want me to send a patch or just commit something to suppress
> this?
Yes, that'd be appreciated.
Thanks!
Takashi
