Hi Michael, On Sat, Jul 6, 2019 at 9:05 AM Michael Kelley <mikelley@xxxxxxxxxxxxx> wrote: > > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Sent: Friday, July 5, 2019 1:31 AM > > > > After merging the kbuild tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > In file included from <command-line>: > > include/clocksource/hyperv_timer.h:18:10: fatal error: asm/mshyperv.h: No such file or > > directory > > #include <asm/mshyperv.h> > > ^~~~~~~~~~~~~~~~ > > > > Caused by commit > > > > 34085aeb5816 ("kbuild: compile-test kernel headers to ensure they are self-contained") > > > > interacting with commit > > > > dd2cb348613b ("clocksource/drivers: Continue making Hyper-V clocksource ISA agnostic") > > > > from the tip tree. > > > > Thomas -- let's remove my two clocksource patches from your 'tip' tree. I'll need > a little time to fully understand the self-contained header requirements and restructure > hyperv_timer.h to avoid this problem. I do not think you have to drop your patches. Since <asm/mshyperv.h> only exists in x86, guarding it by CONFIG_X86 is OK. So, I think Stephen's patch is OK as-is. Perhaps, Kbuild is imposing too much burden, but I'd like to try it and see how it goes. -- Best Regards Masahiro Yamada