On 04-07-19, 19:41, Stephen Rothwell wrote: > Hi all, > > After merging the pm tree, today's linux-next build (x86_64 allnoconfig) > failed like this: > > In file included from kernel/power/qos.c:33: > include/linux/pm_qos.h: In function 'dev_pm_qos_read_value': > include/linux/pm_qos.h:205:9: error: expected '(' before 'type' > switch type { > ^~~~ > ( > include/linux/pm_qos.h:205:9: warning: statement with no effect [-Wunused-value] > switch type { > ^~~~ > include/linux/pm_qos.h:216:1: warning: no return statement in function returning non-void [-Wreturn-type] > } > ^ > include/linux/pm_qos.h: At top level: > include/linux/pm_qos.h:231:4: error: expected identifier or '(' before '{' token > { return 0; } > ^ > In file included from kernel/power/qos.c:33: > include/linux/pm_qos.h:228:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function] > static inline int dev_pm_qos_add_notifier(struct device *dev, > ^~~~~~~~~~~~~~~~~~~~~~~ > > Caused by commits > > 024a47a2732d ("PM / QOS: Pass request type to dev_pm_qos_{add|remove}_notifier()") > 57fa6137402b ("PM / QOS: Pass request type to dev_pm_qos_read_value()") Yeah, I have already sent the replacement patchset to Rafael. -- viresh