On Thu, Jun 13, 2019 at 03:32:15PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_suspend': > drivers/tty/serial/stm32-usart.c:1298:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration] > pinctrl_pm_select_sleep_state(dev); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_resume': > drivers/tty/serial/stm32-usart.c:1307:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration] > pinctrl_pm_select_default_state(dev); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Caused by commit > > c70669ecef4e ("serial: stm32: select pinctrl state in each suspend/resume function") Yeah, I think I need to just go revert that patch now, thanks. greg k-h