Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/phy/phylink.c
between commit:
c678726305b9 ("net: phylink: ensure consistent phy interface mode")
from the net tree and commit:
27755ff88c0e ("net: phylink: Add phylink_mac_link_{up, down} wrapper functions")
from the net-next tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc drivers/net/phy/phylink.c
index 9044b95d2afe,68d0a89c52be..000000000000
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@@ -399,6 -414,36 +418,36 @@@ static const char *phylink_pause_to_str
}
}
+ static void phylink_mac_link_up(struct phylink *pl,
+ struct phylink_link_state link_state)
+ {
+ struct net_device *ndev = pl->netdev;
+
++ pl->cur_interface = link_state.interface;
+ pl->ops->mac_link_up(pl->config, pl->link_an_mode,
- pl->phy_state.interface,
- pl->phydev);
++ pl->cur_interface, pl->phydev);
+
+ if (ndev)
+ netif_carrier_on(ndev);
+
+ phylink_info(pl,
+ "Link is Up - %s/%s - flow control %s\n",
+ phy_speed_to_str(link_state.speed),
+ phy_duplex_to_str(link_state.duplex),
+ phylink_pause_to_str(link_state.pause));
+ }
+
+ static void phylink_mac_link_down(struct phylink *pl)
+ {
+ struct net_device *ndev = pl->netdev;
+
+ if (ndev)
+ netif_carrier_off(ndev);
+ pl->ops->mac_link_down(pl->config, pl->link_an_mode,
- pl->phy_state.interface);
++ pl->cur_interface);
+ phylink_info(pl, "Link is Down\n");
+ }
+
static void phylink_resolve(struct work_struct *w)
{
struct phylink *pl = container_of(w, struct phylink, resolve);
Attachment:
pgpQsqGWM9WzL.pgp
Description: OpenPGP digital signature
