Hi, Stephen Thanks for notice. As it is intentional, I will send out a patch to add "/* fall through */" to avoid this build warning, Anson. > -----Original Message----- > From: Stephen Rothwell [mailto:sfr@xxxxxxxxxxxxxxxx] > Sent: Tuesday, April 30, 2019 8:20 AM > To: Mike Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd > <sboyd@xxxxxxxxxx> > Cc: Linux Next Mailing List <linux-next@xxxxxxxxxxxxxxx>; Linux Kernel Mailing > List <linux-kernel@xxxxxxxxxxxxxxx>; Anson Huang <anson.huang@xxxxxxx>; > Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>; Kees Cook > <keescook@xxxxxxxxxxxx> > Subject: linux-next: build warning after merge of the clk tree > > Hi all, > > After merging the clk tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [- > Wimplicit-fallthrough=] > pll->denom_offset = PLL_IMX7_DENOM_OFFSET; > ^ > drivers/clk/imx/clk-pllv3.c:454:2: note: here > case IMX_PLLV3_AV: > ^~~~ > > Introduced by commit > > 01d0a541ff4b ("clk: imx: correct i.MX7D AV PLL num/denom offset") > > I get this warning because I am building with -Wimplicit-fallthrough in > attempt to catch new additions early. The gcc warning can be turned off by > adding a /* fall through */ comment at the point the fall through happens > (assuming that the fall through is intentional). > > -- > Cheers, > Stephen Rothwell
