Hi all, After merging the bpf-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: kernel/sysctl.c:1238:13: error: 'sysctl_bpf_stats_enabled' undeclared here (not in a function); did you mean 'sysctl_base_table'? .data = &sysctl_bpf_stats_enabled, ^~~~~~~~~~~~~~~~~~~~~~~~ sysctl_base_table Caused by commit 492ecee892c2 ("bpf: enable program stats") CONFIG_BPF=y # CONFIG_BPF_SYSCALL is not set I applied the following patch for today, but it should be done properly. Also this patch leaves proc_dointvec_minmax_bpf_stats() as an unused function. From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Thu, 28 Feb 2019 12:26:58 +1100 Subject: [PATCH] bpf: hack to make "enable program stats" build Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- kernel/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 86e0771352f2..80a70f69cbd5 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1232,7 +1232,6 @@ static struct ctl_table kern_table[] = { .extra1 = &one, .extra2 = &one, }, -#endif { .procname = "bpf_stats_enabled", .data = &sysctl_bpf_stats_enabled, @@ -1242,6 +1241,7 @@ static struct ctl_table kern_table[] = { .extra1 = &zero, .extra2 = &one, }, +#endif #if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU) { .procname = "panic_on_rcu_stall", -- 2.20.1 -- Cheers, Stephen Rothwell
Attachment:
pgpPr8C4hAFZU.pgp
Description: OpenPGP digital signature