Hi all,
After merging the xarray tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from include/linux/uio.h:12,
from include/linux/socket.h:8,
from include/rdma/rdma_cm.h:37,
from drivers/infiniband/core/restrack.c:6:
drivers/infiniband/core/restrack.c: In function 'rt_xa_alloc_cyclic':
include/linux/kernel.h:40:18: warning: passing argument 3 of '__xa_alloc' makes pointer from integer without a cast [-Wint-conversion]
#define U32_MAX ((u32)~0U)
^~~~~~~~~~
drivers/infiniband/core/restrack.c:26:27: note: in expansion of macro 'U32_MAX'
err = __xa_alloc(xa, id, U32_MAX, entry, GFP_KERNEL);
^~~~~~~
In file included from include/linux/radix-tree.h:31,
from include/linux/fs.h:15,
from include/linux/seq_file.h:11,
from arch/powerpc/include/asm/machdep.h:12,
from arch/powerpc/include/asm/archrandom.h:7,
from include/linux/random.h:166,
from include/linux/net.h:22,
from include/linux/skbuff.h:29,
from include/linux/if_arp.h:26,
from include/rdma/ib_addr.h:39,
from include/rdma/rdma_cm.h:39,
from drivers/infiniband/core/restrack.c:6:
include/linux/xarray.h:524:61: note: expected 'void *' but argument is of type 'unsigned int'
int __must_check __xa_alloc(struct xarray *, u32 *id, void *entry,
~~~~~~^~~~~
drivers/infiniband/core/restrack.c:26:36: error: incompatible type for argument 4 of '__xa_alloc'
err = __xa_alloc(xa, id, U32_MAX, entry, GFP_KERNEL);
^~~~~
In file included from include/linux/radix-tree.h:31,
from include/linux/fs.h:15,
from include/linux/seq_file.h:11,
from arch/powerpc/include/asm/machdep.h:12,
from arch/powerpc/include/asm/archrandom.h:7,
from include/linux/random.h:166,
from include/linux/net.h:22,
from include/linux/skbuff.h:29,
from include/linux/if_arp.h:26,
from include/rdma/ib_addr.h:39,
from include/rdma/rdma_cm.h:39,
from drivers/infiniband/core/restrack.c:6:
include/linux/xarray.h:525:3: note: expected 'struct xa_limit' but argument is of type 'void *'
struct xa_limit, gfp_t);
^~~~~~~~~~~~~~~
drivers/infiniband/core/restrack.c:29:28: warning: passing argument 3 of '__xa_alloc' makes pointer from integer without a cast [-Wint-conversion]
err = __xa_alloc(xa, id, *next, entry, GFP_KERNEL);
^~~~~
In file included from include/linux/radix-tree.h:31,
from include/linux/fs.h:15,
from include/linux/seq_file.h:11,
from arch/powerpc/include/asm/machdep.h:12,
from arch/powerpc/include/asm/archrandom.h:7,
from include/linux/random.h:166,
from include/linux/net.h:22,
from include/linux/skbuff.h:29,
from include/linux/if_arp.h:26,
from include/rdma/ib_addr.h:39,
from include/rdma/rdma_cm.h:39,
from drivers/infiniband/core/restrack.c:6:
include/linux/xarray.h:524:61: note: expected 'void *' but argument is of type 'u32' {aka 'unsigned int'}
int __must_check __xa_alloc(struct xarray *, u32 *id, void *entry,
~~~~~~^~~~~
drivers/infiniband/core/restrack.c:29:35: error: incompatible type for argument 4 of '__xa_alloc'
err = __xa_alloc(xa, id, *next, entry, GFP_KERNEL);
^~~~~
In file included from include/linux/radix-tree.h:31,
from include/linux/fs.h:15,
from include/linux/seq_file.h:11,
from arch/powerpc/include/asm/machdep.h:12,
from arch/powerpc/include/asm/archrandom.h:7,
from include/linux/random.h:166,
from include/linux/net.h:22,
from include/linux/skbuff.h:29,
from include/linux/if_arp.h:26,
from include/rdma/ib_addr.h:39,
from include/rdma/rdma_cm.h:39,
from drivers/infiniband/core/restrack.c:6:
include/linux/xarray.h:525:3: note: expected 'struct xa_limit' but argument is of type 'void *'
struct xa_limit, gfp_t);
^~~~~~~~~~~~~~~
Caused by commit
fd47c2f99f04 ("RDMA/restrack: Convert internal DB from hash to XArray")
from the rdma tree interacting with commit
a3e4d3f97ec8 ("XArray: Redesign xa_alloc API")
from the xarray tree.
I added the following merge fix patch:
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Thu, 21 Feb 2019 17:07:22 +1100
Subject: [PATCH] RDMA/restrack: fix for __xa_alloc() API change
Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
---
drivers/infiniband/core/restrack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/restrack.c b/drivers/infiniband/core/restrack.c
index fa804093fafb..5cb381a986c1 100644
--- a/drivers/infiniband/core/restrack.c
+++ b/drivers/infiniband/core/restrack.c
@@ -23,10 +23,10 @@ static int rt_xa_alloc_cyclic(struct xarray *xa, u32 *id, void *entry,
*id = 0;
xa_lock(xa);
- err = __xa_alloc(xa, id, U32_MAX, entry, GFP_KERNEL);
+ err = __xa_alloc(xa, id, entry, XA_LIMIT(*id, U32_MAX), GFP_KERNEL);
if (err && *next != U32_MAX) {
*id = 0;
- err = __xa_alloc(xa, id, *next, entry, GFP_KERNEL);
+ err = __xa_alloc(xa, id, entry, XA_LIMIT(0, *next), GFP_KERNEL);
}
if (!err)
--
2.20.1
--
Cheers,
Stephen Rothwell
Attachment:
pgp2G9QIKNSdl.pgp
Description: OpenPGP digital signature
