On Tue, Feb 19, 2019 at 12:19 PM Hugo Lefeuvre <hle@xxxxxxxxxx> wrote:
>
> > I'm not sending a pull request for this if it breaks any architectures,
> > so I think we need to fix them all, and I suppose we also have to
> > change all architectures in the same patch that changes the architecture
> > independent declaration, so it doesn't break intermittently.
> >
> > At this point, I'd probably drop your patches from my asm-generic
> > tree entirely to avoid the regression, and wait for you to resend
> > them all after 5.1-rc1, for inclusion in 5.2.
> >
> > Can you elaborate on the original problem that you saw? Maybe
> > we can have a different workaround for it in the meantime.
>
> Agree, these two patches should be dropped:
>
> 1. iomap: add missing const to ioread*/iowrite addr arg
>
> since there are incompatible definitions or declarations in
>
> arch/alpha/include/asm/core_apecs.h
> arch/alpha/include/asm/core_cia.h
> arch/alpha/include/asm/core_lca.h
> arch/alpha/include/asm/core_marvel.h
> arch/alpha/include/asm/core_mcpcia.h
> arch/alpha/include/asm/core_t2.h
> arch/alpha/include/asm/io.h
> arch/alpha/include/asm/io_trivial.h
> arch/alpha/include/asm/jensen.h
> arch/alpha/include/asm/machvec.h
> arch/alpha/kernel/core_marvel.c
> arch/alpha/kernel/io.c
> arch/parisc/lib/iomap.c
> arch/powerpc/kernel/iomap.c
> arch/sh/kernel/iomap.c
>
> 2. lib/iomap: add missing const to mmio_ins* addr arg
>
> since there are incompatible definitions or declarations in
>
> arch/sh/kernel/iomap.c
>
> I will resubmit them with all changes required for arch/. The ones for
> alpha, powerpc and sh are already ready and built with cross compiler.
> I still have to setup a cross compiler to build my parisc changes.
I've dropped all your patches for the moment, since one of the remaining
ones had a conflict against changes in the char-misc tree, and the
last one didn't do much by itself.
Please submit the full set again after -rc1.
Arnd
