Hi all,
On Wed, 2 Jan 2019 15:01:40 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> After merging the vfs tree, today's linux-next build (x86_64 allnoconfig)
> failed like this:
>
> fs/fs_context.c: In function 'logfc':
> fs/fs_context.c:400:3: error: implicit declaration of function 'vprintk_emit'; did you mean 'dev_printk_emit'? [-Werror=implicit-function-declaration]
> vprintk_emit(0, LOGLEVEL_WARNING, NULL, 0, fmt, va);
> ^~~~~~~~~~~~
> dev_printk_emit
>
> Caused by commit
>
> e6d72ffc503f ("vfs: Implement logging through fs_context")
>
> # CONFIG_PRINTK is not set
>
> I added the following hack for today:
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Wed, 2 Jan 2019 14:57:36 +1100
> Subject: [PATCH] vfs: work around CONFIG_PRINTK=n in fs_context logging code
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
> fs/fs_context.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index 8728d49c7871..b0324598f573 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -391,6 +391,7 @@ EXPORT_SYMBOL(vfs_dup_fs_context);
> */
> void logfc(struct fs_context *fc, const char *fmt, ...)
> {
> +#ifdef CONFIG_PRINTK
> va_list va;
>
> va_start(va, fmt);
> @@ -409,6 +410,7 @@ void logfc(struct fs_context *fc, const char *fmt, ...)
>
> pr_cont("\n");
> va_end(va);
> +#endif
> }
> EXPORT_SYMBOL(logfc);
>
Ping?
--
Cheers,
Stephen Rothwell
Attachment:
pgp9bn60mE3mJ.pgp
Description: OpenPGP digital signature
