On Fri, Dec 21, 2018 at 10:51 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> On Fri, Dec 21, 2018 at 10:44 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > On 12/21/18 12:32 AM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > News: there will be no linux-next release until Jan 2. Have a good break.
> > >
> > > Changes since 20181220:
> > >
> >
> > on x86_64:
> >
> > ld: drivers/nvdimm/security.o: in function `nvdimm_request_key':
> > security.c:(.text+0xbe): undefined reference to `key_type_encrypted'
> > ld: drivers/nvdimm/security.o: in function `nvdimm_lookup_user_key.isra.1':
> > security.c:(.text+0x1ea): undefined reference to `key_type_encrypted'
> >
> >
> > Full randconfig file is attached.
>
> Could you send me that randconfig, offlist is fine.
>
> It seems the "depends on ENCRYPTED_KEYS" I added is not sufficient.
Yup, I overlooked the LIBNVDIMM=y + ENCRYPTED_KEYS=m case.
I folded a fix into the problematic commit and added a Reported-by
credit. The option is now:
config NVDIMM_KEYS
def_bool y
depends on ENCRYPTED_KEYS
depends on (LIBNVDIMM=ENCRYPTED_KEYS) || LIBNVDIMM=m
