Hi Alexei, On Wed, 12 Dec 2018 12:53:11 -0800 Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Thu, Dec 13, 2018 at 07:32:45AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Commits > > > > 3bdc28aa2340 ("selftests/bpf: add btf annotations for cgroup_local_storage maps") > > 1dfd1959fed4 ("bpf: add bpffs pretty print for cgroup local storage maps") > > 3adc62d9a5be ("bpf: pass struct btf pointer to the map_check_btf() callback") > > 9cf3a785dc4c ("selftests/bpf: use __bpf_constant_htons in test_prog.c") > > > > are missing a Signed-off-by from their committers. > > the must be a script mistake? > > I clearly see SOBs for all of them. For example: commit 3bdc28aa2340bf1e5af753287b373522bd1c02a9 (bpf-next/master) Author: Roman Gushchin <guroan@xxxxxxxxx> Date: Mon Dec 10 15:43:02 2018 -0800 selftests/bpf: add btf annotations for cgroup_local_storage maps Add btf annotations to cgroup local storage maps (per-cpu and shared) in the network packet counting example. Signed-off-by: Roman Gushchin <guro@xxxxxx> Cc: Alexei Starovoitov <ast@xxxxxxxxxx> Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx> Acked-by: Martin KaFai Lau <kafai@xxxxxx> Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx> But it was committed by you, not Daniel. -- Cheers, Stephen Rothwell
Attachment:
pgpE9sAh82dCa.pgp
Description: OpenPGP digital signature