On Fri, 2018-11-30 at 09:43 +0200, Kalle Valo wrote: > Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> writes: > > > Hi Kalle, > > > > On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo <kvalo@xxxxxxxxxxxxxx > > > wrote: > > > I take it that -Wimplict-fallthrough is not enabled by default > > > yet? So > > > Dave and Linus won't see these warnings? > > > > Correct. > > > > > What I'm planning is to send a pull request to Dave today and fix > > > these > > > warnings in the next pull request. Does that sound good? > > > > That sounds fine. > > Great, thanks for the confirmation. I'll then send the pull request > today. Just FYI, I enabled this by default in our internal tree so we will notice when it happens before sending the patch upstream. -- Cheers, Luca.