On 11/30/2018 11:00 AM, Stephen Rothwell wrote:
> Hi Andrew,
>
> After merging the akpm tree, today's linux-next build (powerpc_le perf)
> failed like this:
>
> bench/numa.c: In function 'bind_to_node':
> bench/numa.c:301:21: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'?
> if (target_node == NUMA_NO_NODE) {
> ^~~~~~~~~~~~
> NUMA_NUM_NODES
> bench/numa.c:301:21: note: each undeclared identifier is reported only once for each function it appears in
> bench/numa.c: In function 'bind_to_memnode':
> bench/numa.c:342:14: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'?
> if (node == NUMA_NO_NODE)
> ^~~~~~~~~~~~
> NUMA_NUM_NODES
> bench/numa.c: In function 'init_thread_data':
> bench/numa.c:1366:19: error: 'NUMA_NO_NODE' undeclared (first use in this function); did you mean 'NUMA_NUM_NODES'?
> td->bind_node = NUMA_NO_NODE;
> ^~~~~~~~~~~~
> NUMA_NUM_NODES
>
> Caused by patch
>
> "mm: replace all open encodings for NUMA_NO_NODE"
>
> I applied the following partial revert for today:
I had skipped this particular file because it includes 'numa.h'. But that does not
seem to pull in <linux/numa.h> though. Could we please add <linux/numa.h> instead
of reverting the actual changes from the patch. I can send out another version of
the patch if required.
- Anshuman
