Hi Jaegeuk, On Mon, 26 Nov 2018 14:22:57 -0800 Jaegeuk Kim <jaegeuk@xxxxxxxxxx> wrote: > > Is this okay? That looks great, thanks. > From: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Date: Mon, 26 Nov 2018 14:20:32 -0800 > Subject: [PATCH] f2fs: avoid build warn of fall_through > > After merging the f2fs tree, today's linux-next build > (x86_64_allmodconfig) produced this warning: > > In file included from fs/f2fs/dir.c:11: > fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag': > fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (set) > ^ > fs/f2fs/f2fs.h:2390:2: note: here > case FI_DATA_EXIST: > ^~~~ > > Exposed by my use of -Wimplicit-fallthrough > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > --- > fs/f2fs/f2fs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 26ad1de8641c..b3fe6803d4c6 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode, > case FI_NEW_INODE: > if (set) > return; > + /* fall through */ > case FI_DATA_EXIST: > case FI_INLINE_DOTS: > case FI_PIN_FILE: > -- -- Cheers, Stephen Rothwell
Attachment:
pgp4JQs1kd82J.pgp
Description: OpenPGP digital signature
