On 11/3/18 3:58 PM, Miguel Ojeda wrote: > On Sat, Nov 3, 2018 at 5:10 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> >> No plugins are enabled. >> The failing randconfig file (for x86_64) is attached. > > Confirmed with a built-from-sources 4.8.5 on current master > (d2ff0ff2c23f). The ICE also happens with 4.6.4. With 8.1.0, however, > we get an error instead: > > In file included from drivers/media/usb/dvb-usb/pctv452e.c:20: > drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach': > ./drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak > declaration of 'stb0899_attach' being applied to a already existing, > static definition > static inline struct dvb_frontend *stb0899_attach(struct > stb0899_config *config, > ^~~~~~~~~~~~~~ > > Which seems to have been spotted by kbuild months ago: > > https://lkml.org/lkml/2018/3/10/358 > > The problem is in pctv452e_frontend_attach(): > > /* > * dvb_frontend will call dvb_detach for both stb0899_detach > * and stb0899_release but we only do dvb_attach(stb0899_attach). > * Increment the module refcount instead. > */ > symbol_get(stb0899_attach); > > Here symbol_get() is declaring a weak function (due to > !CONFIG_MODULES) while this definition in stb0899_drv.h occurs (due to > !CONFIG_DVB_STB0899): > > static inline struct dvb_frontend *stb0899_attach(struct stb0899_config *config, > struct i2c_adapter *i2c) > { > printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__); > return NULL; > } > > I guess pctv452e should require CONFIG_DVB_STB0899, or similar. CC'ing > Mauro, Wolfgang, linux-media. > > Hope that helps! Thanks for digging into this. :) cheers. -- ~Randy
