On Tue, Sep 11, 2018 at 11:43 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > On Tue, 11 Sep 2018, Nicolas Ferre wrote: > > Actually it is due to the missing of <linux/mod_devicetable.h> as Stephen > > suggested. It is due to the patch ac3167257b9f ("headers: separate > > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1. > > Since this set uses Device Tree, it really should include the of.h. I didn't remember the contents of the driver, but I would disagree on a statement that *using* of_device_id table implies necessity of linux/of.h inclusion. > > This solves the issue reported above. > > I will fix-up and re-send the pull-request. -- With Best Regards, Andy Shevchenko