On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id' > static const struct of_device_id at91_usart_mode_of_match[] = { > ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer > { .compatible = "atmel,at91rm9200-usart" }, > ^ > drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match') > drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer > { .compatible = "atmel,at91sam9260-usart" }, > ^ > drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match') > drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable] > static const struct of_device_id at91_usart_mode_of_match[] = { > ^~~~~~~~~~~~~~~~~~~~~~~~ > > Caused by commit > > 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART") > > Forgot to include <linux/mod_devicetable.h>? > > I used the version of the tty tree from next-20180910 for today. Very odd, I just pulled in the "Immutable" branch from Lee here. Lee, is there something I am missing to get this to build properly? thanks, greg k-h