Hi Andrew,
After merging the akpm tree, today's linux-next build (powerpc
allyesconfig) failed like this:
security/keys/big_key.c: In function 'big_key_free_buffer':
security/keys/big_key.c:146:3: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
vunmap(buf->virt);
^~~~~~
kunmap
security/keys/big_key.c: In function 'big_key_alloc_buffer':
security/keys/big_key.c:187:14: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
buf->virt = vmap(buf->pages, buf->nr_pages, VM_MAP, PAGE_KERNEL);
^~~~
kmap
security/keys/big_key.c:187:46: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_SAO'?
buf->virt = vmap(buf->pages, buf->nr_pages, VM_MAP, PAGE_KERNEL);
^~~~~~
VM_SAO
security/keys/big_key.c:187:46: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
d9f4bb1a0f4d ("KEYS: Use individual pages in big_key for crypto buffers")
in Linus' tree, but most likely exposed by commit
e8bd5e5c63b6 ("headers: untangle kmemleak.h from mm.h")
in the akpm-current tree (kmemleak.h includes vmalloc.h).
I have added the following patch for today:
From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Mon, 26 Feb 2018 15:58:03 +1100
Subject: [PATCH] KEYS: include vmalloc.h for vmap etc
This was discovered after a patch that removed kmemleak.h from slab.h.
Fixes: d9f4bb1a0f4d ("KEYS: Use individual pages in big_key for crypto buffers")
Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
---
security/keys/big_key.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/keys/big_key.c b/security/keys/big_key.c
index fa728f662a6f..e5823de23f4f 100644
--- a/security/keys/big_key.c
+++ b/security/keys/big_key.c
@@ -18,6 +18,7 @@
#include <linux/err.h>
#include <linux/scatterlist.h>
#include <linux/random.h>
+#include <linux/vmalloc.h>
#include <keys/user-type.h>
#include <keys/big_key-type.h>
#include <crypto/aead.h>
--
2.16.1
Linus, is it worth putting this directly into your tree, or should it
just wait for the patch from Andrew's tree that exposes it?
--
Cheers,
Stephen Rothwell
Attachment:
pgpxS1bZz1P46.pgp
Description: OpenPGP digital signature
