On Thu 30 Nov 16:28 PST 2017, Pavel Machek wrote: > Hi! > > > > > of_device_get_match_data will return PM8058_LED_TYPE_* > > > > which clearly is a led type identifier. > > > > > > > > Thus unsigned long looks reasonable. > > > > > > Hmm. Ok. So u32 would actually make even more sense there (because > > > PM8058_LED_TYPE_* does not really need to be 64-bit), but it would > > > cause a warning. > > > > > > I don't like this. This fix actually makes code waste memory and is > > > uglier. > > > > > > ...but we get a warning fix. So I don't like the patch, but it is an > > > improvement... > > > > I *think* you can get away with (u32)(unsigned long)ptr ... > > Yes, that should work. It would actually be my preferred solution. > I'm fine with this suggestion, and it silence the warning. I will update and resend the patch. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
