Hi Dan, Today's linux-next merge of the nvdimm tree got a conflict in: fs/ext4/inode.c between commit: 545052e9e35a ("ext4: Switch to iomap for SEEK_HOLE / SEEK_DATA") from the ext4 tree and commit: 31bc9582e43d ("ext4: Support for synchronous DAX faults") from the nvdimm tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. Thanks, Dan, for the heads up and sample resolutions. -- Cheers, Stephen Rothwell diff --cc fs/ext4/inode.c index 14bff666d2fc,13a198924a0f..000000000000 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@@ -3394,6 -3393,20 +3394,19 @@@ static int ext4_releasepage(struct pag return try_to_free_buffers(page); } -#ifdef CONFIG_FS_DAX + static bool ext4_inode_datasync_dirty(struct inode *inode) + { + journal_t *journal = EXT4_SB(inode->i_sb)->s_journal; + + if (journal) + return !jbd2_transaction_committed(journal, + EXT4_I(inode)->i_datasync_tid); + /* Any metadata buffers to write? */ + if (!list_empty(&inode->i_mapping->private_list)) + return true; + return inode->i_state & I_DIRTY_DATASYNC; + } + static int ext4_iomap_begin(struct inode *inode, loff_t offset, loff_t length, unsigned flags, struct iomap *iomap) { -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html