Bart Van Assche <Bart.VanAssche@xxxxxxx> writes: > On Wed, 2017-08-16 at 22:30 +0530, Abdul Haleem wrote: >> As of next-20170809, linux-next on powerpc boot hung with below trace >> message. >> [ ... ] >> System booted fine when the below commit is reverted: > > Hello Abdul, > > Can you check whether applying the following commit on top of next-20170809 > fixes this regression: > > https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=4.13/scsi-fixes&id=b0e17a9b0df29590c45dfb296f541270a5941f41 That's already in next-20170816, which still exhibits the bug. We know that reverting it fixes the bug, but I can also fix it by doing a partial revert, ie: diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 582769116f66..95f1428c5bc9 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -190,7 +190,9 @@ static void __scsi_queue_insert(struct scsi_cmnd *cmd, int reason, int unbusy) */ cmd->result = 0; if (q->mq_ops) { - scsi_mq_requeue_cmd(cmd); + struct scsi_device *sdev = cmd->device; + blk_mq_requeue_request(cmd->request, true); + put_device(&sdev->sdev_gendev); return; } spin_lock_irqsave(q->queue_lock, flags); That's basically inlining the old version of scsi_mq_requeue_cmd() at the other call site in __scsi_queue_insert(). Now I guess that was fairly obvious, if you look closely at the commit, and the fact that we're not hitting the WARN_ON() you added. Anyway let me know if there's anything else I can try. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
