On 06/28/2017 06:43 AM, Jens Axboe wrote: > On 06/28/2017 02:04 AM, Stephen Rothwell wrote: >> Hi Jens, >> >> After merging the block tree, today's linux-next build (powerpc >> allnoconfig) failed like this: >> >> fs/fcntl.o: In function `do_fcntl': >> fcntl.c:(.text+0x6d4): undefined reference to `__get_user_bad' >> fcntl.c:(.text+0x730): undefined reference to `__get_user_bad' >> >> Probably caused by commit >> >> c75b1d9421f8 ("fs: add fcntl() interface for setting/getting write life time hints") >> >> On powerpc (at least) you cannot use get_user() to fetch anything larger >> than "unsigned long" i.e. 32 bits on 32 bit powerpc. >> >> This has been discussed before (and, I think, a fix attempted). > > Gah, thanks for letting me know. I'll test your patch and queue it > up to fix this issue. But put_user() is fine? Just checking here, since the change adds both a u64 put and get user. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html