On Thu, Oct 27, 2016 at 4:01 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Oct 27, 2016 at 3:48 PM, Linus Torvalds > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >> >> I wonder if we should make KASAN depend on !COMPILE_TEST, because it >> does seem to disable a lot of build-time testing. > > Actually, we should probably just make the MEMORY_HOTPLUG dependency be > > depends on COMPILE_TEST || !KASAN Maybe we could just reverse the MEMORY_HOTPLUG->!KASAN dependency to make it KASAN->!MEMORY_HOTPLUG? Is it at all correct that allmodconfig enables KASAN? If/when we have other compiler-based tools, which of them will allmodconfig pick? > since the memory-hotplug code should still *build* with KASAN, it just > doesn't work. That's exactly what the COMPILE_TEST config option is > there for - to get build coverage even for things that aren't > necessarily sane to run. > > I'll do that, to get my build coverage up. I really expected my > allmodconfig builds to verify that I had removed the per-zone > waitqueue code completely, and I'm happy that the breakage was > apparently limited to that unused variable.. > > In the meantime, thanks for noticing and letting me know. > > Linus -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
